Fix VS Code extract function refactoring#171
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VS Code extract-function refactor produced poorly formatted functions and duplicate or missing parameters for selected PowerShell blocks. This updates extraction to preserve the selected block's base indentation, indent the generated function body consistently, and derive parameters from variables that are read before being assigned within the selection.
The parameter generation now de-duplicates variables, ignores common automatic variables, includes read-before-write assignment cases, and adds simple type hints when the AST makes them clear, such as string comparisons, casts, and path arguments. Regression tests cover the reported indented selection scenario and update the existing extract-function expectations.