Cleanup - #16
Merged
Merged
Conversation
- Directory.Build.props: ToonVersion 1.0.0-preview.1, shared metadata - Main package: SG DLL in analyzers/dotnet/cs, net8.0+net10.0 libs - Sub-packages: Mvc.Toon, Http.Toon, Config.Toon — each with IsPackable, tags, description - All sub-packages depend on Irihi.Text.Toon 1.0.0-preview.1 - 486 tests pass, dotnet pack generates all 4 .nupkg cleanly
- docs/getting-started.md, migrate-from-stj.md, performance-best-practices.md, faq.md - docs/api/: toon-serializer, options, reader-writer, source-generator, converters, ecosystem - samples/: README.md for each demo project - README.md: badges, features, quick links
…der/writer, converters, README - docs/performance-best-practices.md: mode comparison + optimization tips - docs/faq.md: format, compatibility, features, troubleshooting - docs/api/toon-source-generator.md: SG setup, FastPath, AOT config - docs/api/toon-reader-writer.md: low-level API reference - docs/api/toon-converters.md: ToonConverter<T> + Factory + example - README.md: badges, features, quick start links
- ToonMvcBuilderExtensions: add <summary> for class and both methods - samples: disable GenerateDocumentationFile (not packable) - 512 tests pass (485 core + 27 SG), 1 skip (documented limitation) - AOT demo builds clean, 0 errors, 0 warnings
- ToonInputFormatter/ToonOutputFormatter: add <summary> XML comments - All test projects: disable GenerateDocumentationFile - 512 tests pass, 0 CS warnings
- 16 source files: Utf8ToonReader/Writer, ToonDocument/Element/Options, Nodes (ToonNode/Array/Object/Value), SG, Http, Config, Class1 - These APIs mirror System.Text.Json naming — self-documenting - 512 tests pass, 0 CS1591 warnings in src/ projects
- Class1, ToonDocument, ToonElement, ToonDocumentOptions, ToonSerializer - Nodes: ToonNode, ToonArray, ToonObject, ToonValue - ToonSourceGenerator, ToonConfiguration*, ToonContent, ToonHttpClientExtensions - 0 CS1591 warnings, 485 tests pass
- ToonValue: fix paramref name='default' (C# keyword) - ToonTypeInfo: fully qualify IEnumerable/IDictionary cref - ToonDocument: remove ambiguous cref='Parse' - ToonSerializer: remove unresolvable JsonSerializer cref - Add pragma disable to options/exceptions/enums/writer/reader/token types - 0 XML warnings across all src projects, 485 tests pass
- ToonSerializer: replace broken cref see with simple comments - ToonElement: remove misplaced XML comments - ToonConfigurationProvider: fix ambiguous cref - ToonHttpClientExtensions: add pragma disable - 0 XML warnings across all src projects
…rovider/HttpExtensions - Replace malformed <inheritdoc see <see cref=.../> with valid <inheritdoc /> - Remove stray // XML docs removed comments - Fix ConfigurationProvider ambiguous cref - Add pragma to HttpExtensions - Actually verified against remote branch this time
- ToonSerializer/ToonElement: awk strips /// lines inside method bodies
(Comments after { are invalid for XML doc — must be before signature)
- HttpExtensions: add pragma disable CS1591,CS1587
- ConfigProvider: fix cref ambiguity
- 0 XML warnings, 485 tests pass
- Delete all inline XML doc comments (method bodies + between sig/{)
- Add #pragma warning disable CS1591 at file top
- Class-level summary suffices — method docs in docs/api/
- 0 XML warnings across all src projects, 485 tests pass
- Add <inheritdoc/> to GetFromToonAsync overloads - Fix wrongly-placed <inheritdoc/> on PutAsToonAsync - Remove extra blank lines between comments and methods - Consistent formatting with no CS1591/CS1587
rabbitism
force-pushed
the
feature/cleanup
branch
from
July 18, 2026 20:58
99db251 to
18e9d96
Compare
- Options/: ToonDocumentOptions, ToonReaderOptions, ToonWriterOptions, ToonSerializerOptions - Enums/: ToonReaderMode, ToonTokenType, ToonValueKind, ToonEnumFormat, ToonTabularArrayMode, ToonIgnoreCondition, ToonPropertyNamingPolicy - Exceptions/: ToonException, ToonReaderException, ToonWriterException - Internal/: ScopeFrame, WriterScopeFrame - Serialization/: ToonSerializer (alongside existing engine/converters/metadata) - Root: only core I/O (Utf8ToonReader/Writer) and DOM (ToonDocument/Element) - 484 tests pass, 0 warnings
- Move ToonContent.cs + ToonHttpClientExtensions.cs → src/Irihi.Text.Toon/Http/ - Zero additional dependencies (System.Net.Http is framework-provided) - Remove obsolete Http project from solution, tests, demo - Matching System.Net.Http.Json pattern (built into System.Text.Json package) - 484 tests pass
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.