Fix two bugs associated with the -mem option#173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the following changes:
-memoption iqtree2#431 by settingmax_lh_slotsindependently ofcentral_partial_lhto cover the cases wherecentral_partial_lhis copied as inModelMixture::optimizeWithEM(), which was causing the bug.min_lh_slotswithmax_lh_slots, as the former number can be overestimated for small trees with less than 5 leaves.PhyloTree::getMemoryRequired(), correct the memory estimates for UFBoot and site-specific models, make type conversions more explicit, and add more comments.