Skip to content

GENGARVIS-046: fix social card accordion focus and scroll - #48

Merged
iocfinc merged 3 commits into
mainfrom
codex/GENGARVIS-046-social-accordion-scroll-r2
Mar 30, 2026
Merged

GENGARVIS-046: fix social card accordion focus and scroll#48
iocfinc merged 3 commits into
mainfrom
codex/GENGARVIS-046-social-accordion-scroll-r2

Conversation

@iocfinc

@iocfinc iocfinc commented Mar 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • align Social Card controls accordion behavior with Motion/Data Viz single-active-section pattern
  • keep only one section expanded at a time and remove collapsed sibling pills while focused
  • move long-section overflow handling into the active accordion content so controls remain scrollable

Root Cause

Social Card Toolkit kept all accordion sections rendered as individual pills with fixed-height containers, so long control groups could not use the full controls panel and scrolling behavior diverged from other toolkits.

Validation

  • npm run test:ci -- tests/socialCardToolkitPage.test.tsx tests/datavizToolkitPage.test.tsx (pass)
  • Chrome DevTools MCP visual capture attempt blocked by locked profile at /Users/iraoliverfernando/.cache/chrome-devtools-mcp/chrome-profile; no screenshot artifact available in this run.

Issue

Closes #46

@iocfinc iocfinc added the CODEX Assisted by or generated with Codex agents label Mar 24, 2026
@github-actions

Copy link
Copy Markdown

PR review automation completed.

  • Use agent/skills/analyze_pr.md for the review structure.
  • Confirm architecture impact is acceptable.
  • Confirm tests cover changed behavior.
  • When shared toolkit behavior changes, verify sibling-toolkit consistency was checked or explicitly ruled out.
  • Verify CHANGELOG.md is updated when required.
  • For frontend-affecting work, confirm screenshot artifacts or an explicit skip reason are included in the PR notes, with Chrome DevTools MCP preferred when configured.
  • Confirm the linked issue was updated or a post-ready draft was prepared when live posting was deferred.

@iocfinc
iocfinc merged commit 78d68ff into main Mar 30, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CODEX Assisted by or generated with Codex agents

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Scrolling Support in Data Vis and Social Card

1 participant