Skip to content

STAR WARS app - #1

Open
ioanadin wants to merge 41 commits into
masterfrom
implementation
Open

STAR WARS app#1
ioanadin wants to merge 41 commits into
masterfrom
implementation

Conversation

@ioanadin

Copy link
Copy Markdown
Owner

No description provided.

Comment thread package.json
Comment thread public/index.html
Comment thread src/components/CharacterGallery.js Outdated
Comment thread src/components/CharacterGallery.js Outdated
Comment thread src/components/CharacterGallery.js Outdated
Comment thread src/components/CharacterItem.css
Comment thread src/components/CharacterItem.js Outdated
Comment thread src/components/Gallery.js Outdated
Comment thread src/components/Gallery.js Outdated
Comment thread src/components/Gallery.js Outdated
Comment thread src/components/Header.js Outdated
Comment thread src/components/OpeningCrawl.css
Comment thread src/components/OpeningCrawl.js Outdated
Comment thread src/index.js
Comment thread src/util/swapi.js
Comment thread src/util/swapi.js
Comment thread src/util/matchEpisodeToPicture.js Outdated
@@ -0,0 +1,30 @@
import episode1url from '../sw-covers/Star-Wars-Episode-I-The-Phantom-Menace.jpg';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use an array with the paths of the cover images and based on episodeId we can return the element in the array at the position episodeId-1

Comment thread src/components/CharacterItem.js Outdated
Comment thread src/components/Movie.js Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants