feat: support template page ranges - #750
Conversation
|
Nice PR — the capability-flag pattern mirrors Must-fix (blocking CI reds)pre-commit — pydoclint on
pre-commit — ruff-format wants one file reformatted; the long error message strings need wrapping. mypy 3.10 + 3.13 — three test functions in
Should-fix — real correctness concernField-level
(a) is fine as a first cut; (b) is the right long-term shape. Either is acceptable for this PR. Test-coverage gaps
Nits
Not concerns (looked at, all good)
|
|
Thanks, addressed in a96765c.
Side effect: some multi page invioces with crucial info on page 1 but the real invoice on later pages, can no longer parse outside their page boundary. Most notably: some MS invoices, at least here in NL. |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
a96765c to
f2c1e8e
Compare
Summary
Adds an optional top-level template setting: