-
Notifications
You must be signed in to change notification settings - Fork 47
fix: normalize paths in extracted translation files #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mirekys
wants to merge
1
commit into
inveniosoftware:master
Choose a base branch
from
oarepo:contribution-normalize-babel-paths
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # | ||
| # Copyright (C) 2026 CERN. | ||
| # Copyright (C) 2026 CESNET. | ||
| # | ||
| # Invenio-Cli is free software; you can redistribute it and/or modify it | ||
| # under the terms of the MIT License; see LICENSE file for more details. | ||
|
|
||
| """Tests for translations commands.""" | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
|
|
||
| from invenio_cli.commands.translations import TranslationsCommands | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def temp_pot_file(tmp_path): | ||
| """Create a temporary .pot file with absolute paths.""" | ||
| pot_file = tmp_path / "messages.pot" | ||
| pot_file.write_text( | ||
| "# Translations template\n" | ||
| "#, fuzzy\n" | ||
| 'msgid ""\n' | ||
| 'msgstr ""\n' | ||
| f"#: {tmp_path}/test.py:1\n" | ||
| 'msgid "test message"\n' | ||
| 'msgstr ""\n' | ||
| ) | ||
| return pot_file | ||
|
|
||
|
|
||
| def test_normalize_paths(temp_pot_file, tmp_path): | ||
| """Test that absolute paths are normalized to relative paths.""" | ||
| commands = TranslationsCommands(cli_config=None, project_path=tmp_path) | ||
|
|
||
| commands._normalize_paths(str(temp_pot_file), tmp_path) | ||
| content = temp_pot_file.read_text() | ||
|
|
||
| assert str(tmp_path) not in content | ||
| assert "test.py:1" in content | ||
| assert "#: test.py:1" in content | ||
|
|
||
|
|
||
| def test_normalize_paths_no_project_path(temp_pot_file, tmp_path): | ||
| """Test that normalization works when project_path is None.""" | ||
| commands = TranslationsCommands(cli_config=None, project_path=None) | ||
| original_content = temp_pot_file.read_text() | ||
| commands._normalize_paths(str(temp_pot_file), None) | ||
|
|
||
| normalized_content = temp_pot_file.read_text() | ||
| assert original_content == normalized_content | ||
|
|
||
|
|
||
| def test_normalize_paths_file_not_exists(tmp_path): | ||
| """Test that normalization handles non-existent files gracefully.""" | ||
| commands = TranslationsCommands(cli_config=None, project_path=tmp_path) | ||
|
|
||
| # Run the normalization on a non-existent file - should not crash | ||
| commands._normalize_paths(str(tmp_path / "nonexistent.pot"), tmp_path) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that's a win or not since Windows isn't supported.
Perhaps we could also utilize e.g. some
pathlibfunctionality to be smarter about paths than mere string replacement.