Fix Deploy PyPI: ignore W009/W010 for delvewheel-repaired wheels#235
Merged
Conversation
Deploy PyPI has failed since delvewheel started vendoring msvcp140 into python_ics.libs/: check-wheel-contents flags the extra toplevel dir (W009) with no Python modules (W010) on every Windows wheel. Verified against the run-28872960948 artifacts: all 10 Windows wheels fail without the ignore and all pass with it; other checks stay active. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy PyPI has been failing on every master push since delvewheel started vendoring the MSVC runtime:
check-wheel-contentsrejects the repaired Windows wheels becausepython_ics.libs/(containing onlymsvcp140-*.dll) is a second toplevel entry (W009) with no Python modules (W010). That layout is exactly what delvewheel is supposed to produce.Fix
Add
--ignore W009,W010to the check in the deploy job. A[tool.check-wheel-contents]toplevelallowlist was considered and rejected: the macOS/Linux wheels don't containpython_ics.libs/(delocate/auditwheel place libraries differently), so an allowlist would fail those wheels with W201 instead. All other wheel checks stay active.Verification
Reproduced locally against the actual artifacts from failing master run 28872960948:
--ignore W009,W010: all 10 wheels reportOK, exit 0This unblocks the
1!26.3.9release upload (checklist item 0 from #234).🤖 Generated with Claude Code