Skip to content

[PB-6474] bugfix/Photos fixes and improvements#479

Open
CandelR wants to merge 1 commit into
feature/PB-6467-add-photos-from-sdkfrom
feature/PB-6474-fixes-and-improvements
Open

[PB-6474] bugfix/Photos fixes and improvements#479
CandelR wants to merge 1 commit into
feature/PB-6467-add-photos-from-sdkfrom
feature/PB-6474-fixes-and-improvements

Conversation

@CandelR

@CandelR CandelR commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • iOS video thumbnails: Videos in the Photos Library are only accessible for thumbnail generation via PHAsset URI (ph://). Direct /var/mobile/Media/DCIM/ paths fail with NSCocoaErrorDomain 257. Fixed by returning thumbnailUri (the ph:// asset URI) from resolveLocalPath and patching react-native-create-thumbnail to handle ph:// via PHImageManager.
  • Cloud-only 404 on playback: PhotoAssetFetchService was using user.bucket (Drive root) instead of asset.bucket (Photos bucket) when downloading cloud-only assets.
  • Duplicate device folders: ensureDeviceFolder could be called concurrently during app startup, causing the backend created duplicate device folders. Fixed with a pending-promise mutex in PhotoDeviceManagerService.
  • Orphaned device assets in timeline: Assets from deleted devices persisted in local cloud_asset DB indefinitely. syncAllHistory now calls purgeDeletedDevices at the start of each sync cycle.
  • Upload order: oldest assets uploaded first. Changed to ORDER BY creation_time DESC NULLS LAST so recent assets upload first.
  • Video indicator for cloud-only assets: CloudPhotoCell now shows a play icon badge via the new shared VideoBadge.
  • toFileUri updated to pass through any existing URI scheme (://), not just file://.

@CandelR CandelR self-assigned this Jun 4, 2026
@CandelR CandelR added bug Something isn't working enhancement New feature or request labels Jun 4, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants