Add addon C##1391
Open
dajimenezriv-internxt wants to merge 38 commits into
Open
Conversation
| ipcPreloadMain.handle('driveChooseSyncRootWithDialog', () => chooseSyncRootWithDialog({ ctx })); | ||
|
|
||
| // Backups | ||
| ipcPreloadMain.handle('deleteBackupsFromDevice', (_, props) => deleteBackupsFromDevice({ ctx, ...props })); |
Contributor
Author
There was a problem hiding this comment.
This is a fix needed because as said in the previous PR I resolved the conflicts wrongly and this line was duplicated.
| @@ -0,0 +1,154 @@ | |||
| using System.Runtime.CompilerServices; | |||
Contributor
Author
There was a problem hiding this comment.
Same funcionality as in C++.
| @@ -0,0 +1,14 @@ | |||
| CreateFile | |||
Contributor
Author
There was a problem hiding this comment.
Here we need to write all NativeMethods from C++ that we need in the C# code so they can be generated by .NET and used in the C# code.
|
|
||
| public void Start() | ||
| { | ||
| new Thread(Run) { IsBackground = true, Name = "FileWatcher" }.Start(); |
Contributor
Author
There was a problem hiding this comment.
Now managing threads is much more simple.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement the first version of Addon C# for hydrate/dehydrate file and also the watcher. The first 2 functions are very easy and they are working as expected. About the watcher it's the feature more tested in the javascript part and all events are working perfectly. In case something goes wrong we can deactivate the new
AddonCsand use theaddon.