feat: image format --bypass -> --format option#94
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the former --bypass-inspect flag with a more flexible --format option (mcuboot vs any) for firmware uploads/upgrades, while also updating the supported Python/runtime/dependency baseline to align with newer smpclient/typer releases.
Changes:
- Introduces
--format {mcuboot,any}and updatesupgrade/image uploadflows to either locally inspect MCUboot images or skip inspection. - Updates dependency requirements (notably
smpclientv7 andtyperv0.24) and bumps the minimum Python version to 3.11. - Removes Python 3.10 from CI matrices.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
smpmgr/main.py |
Switches upgrade from --bypass-inspect to --format, using local MCUboot TLV parsing only when applicable. |
smpmgr/image_management.py |
Adds ImageFormat/ImageFormatOption and updates image upload to honor --format for local inspection behavior. |
pyproject.toml |
Bumps Python requirement to >=3.11 and updates smpclient/typer dependency constraints. |
poetry.lock |
Refreshes the lockfile to reflect updated dependency versions and extras. |
.github/workflows/test.yaml |
Removes Python 3.10 from the test matrix. |
.github/workflows/lint.yaml |
Removes Python 3.10 from the lint matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b8ceef1 to
50133f6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@JPHutchins sorry for the delay, I've been quite busy with work, but today I tested this implementation and it works well for our needs, thanks! |
Yes, a new version is due, thanks for the reminder! |
FYI @axelnxp
More flexibility for zephyrproject-rtos/zephyr#103999 and zephyrproject-rtos/zephyr#104691
Image inspection and parsing will be added after some breaking changes and reworks. E.g.
smpmgr image <my_file.bin>can parse and display information about an image file.Users wanting inspection of mcuboot images can use the
mcuimgapp included withsmpclient.We're dropping python 3.10 but I don't consider it breaking since this is an app, not a lib. 3.10 is EOL in 6 months anyway.