Skip to content

Fix lastLine() killing the whole process via log.Fatal #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eliasbakken merged 1 commit into from
Aug 10, 2026
+6 −1
Merged

Fix lastLine() killing the whole process via log.Fatal #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion reflash/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,12 @@ func parseXzUncompressedSize(out string) int {
func lastLine(file string) string {
out, err := exec.Command("tail", "-n1", file).Output()
if err != nil {
log.Fatal(err)
// Expected before the progress file exists yet (e.g. right at
// the start of a flash, or in tests) - the caller already
// falls back to 0 on a non-numeric result. log.Fatal here
// used to kill the whole process on this, not just this one
// read.
return ""
}
return strings.TrimSpace(string(out[:]))
}
Expand Down
Loading