Fix #69: install Plymouth ourselves instead of relying on Armbian's flag - #70
Open
eliasbakken wants to merge 1 commit into
Open
Fix #69: install Plymouth ourselves instead of relying on Armbian's flag#70eliasbakken wants to merge 1 commit into
eliasbakken wants to merge 1 commit into
Conversation
Root cause: recore.csc's extension_finish_config__enable_plymouth() hook (which set PLYMOUTH=yes) was commented out and never actually ran - not a BUILD_MINIMAL conflict as first suspected, just dead code that silently did nothing. Rather than re-enable Armbian's own PLYMOUTH/armbian-plymouth-theme mechanism, install plymouth ourselves via a new install_components script, the same way Rebuild already installs Klipper/Moonraker/ weston/etc - avoids depending on Armbian's internal variable semantics, which is exactly what broke this in the first place. - New install_components/plymouth.sh: installs plymouth + plymouth-themes, wires Recore's watermark into the spinner theme's logo (moved from the dead armbian/watermark.png path, which rebuild.sh was copying into a package we never actually build), and re-centers it (the theme's default WatermarkVerticalAlignment of .96 puts it right at the bottom of the screen). - Wired into fluidd/mainsail/octoprint (not barebone - no display). - weston.service now has After=plymouth-quit-wait.service. Found while testing: without it, weston can race Plymouth's DRM handoff and come up with a broken/black display even though the process itself reports healthy - a restart recovers it, but shouldn't be needed. Only affects octoprint (toggle.sh); fluidd/mainsail use KlipperScreen over X11, which was confirmed clean on the same test. Validated end-to-end on real hardware on both fluidd and octoprint builds: splash shows, watermark centered, and (with the matching Reflash rotate-screen PLYMOUTH place change) correctly rotated. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #69. No splash screen during boot on Recore.
Root cause
recore.csc'sextension_finish_config__enable_plymouth()hook (which setPLYMOUTH=yes) was commented out and never actually ran. Not aBUILD_MINIMALconflict as first suspected while investigating - just dead code that silently did nothing. Plymouth was never installed at all.Fix
Rather than re-enable Armbian's own
PLYMOUTH/armbian-plymouth-thememechanism, install plymouth ourselves via a newinstall_componentsscript, the same way Rebuild already installs Klipper/Moonraker/weston/etc. Avoids depending on Armbian's internal variable semantics, which is exactly what broke this in the first place and could break again on a future Armbian bump.install_components/plymouth.sh: installsplymouth+plymouth-themes, wires Recore's watermark into thespinnertheme's logo (moved from the deadarmbian/watermark.pngpath, whichrebuild.shwas copying into a package we never actually build), and re-centers it (the theme's defaultWatermarkVerticalAlignmentof.96puts it right at the bottom of the screen).fluidd/mainsail/octoprint(notbarebone- no display).weston.servicenow hasAfter=plymouth-quit-wait.service. Found while testing: without it, weston can race Plymouth's DRM handoff and come up with a broken/black display even though the process itself reports healthy - a manual restart recovers it, but shouldn't be needed. Only affects octoprint (toggle.sh); fluidd/mainsail use KlipperScreen over X11, which was confirmed clean on the same test.Rotation (
panel_orientation) is handled separately by a matching change to Reflash'srotate-screen(newPLYMOUTHplace).Test plan
plymouth+plymouth-themes, confirmed the splash renders on this kernel/hardware at all)rebuild-fluiddandrebuild-octoprintlocally with these changes and flashed both to real hardwareweston.serviceordering fix, hit the black-screen race; with it, Toggle comes up clean without a manual restart🤖 Generated with Claude Code