[Mos] Fix Xe media engine reset on 32-bit media-driver#2005
Open
matte-schwartz wants to merge 1 commit into
Open
[Mos] Fix Xe media engine reset on 32-bit media-driver#2005matte-schwartz wants to merge 1 commit into
matte-schwartz wants to merge 1 commit into
Conversation
batch_addrs[0] (uint64_t) was cast through uintptr_t before assignment to exec.address (__u64). On 32-bit builds this truncates GPU VAs above 4GB, causing the kernel to reject or fault the dispatch and reset the media engine. Pass batch_addrs[0] directly. For the array pointer branch, use the standard (uint64_t)(uintptr_t) idiom. Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Author
|
Sorry, I was under the impression given some older merged PRs in this repo (#1493) that 32-bit was somewhat supported, but I see now I was mistaken and that you've stated 32-bit builds are not supported: #1989 (comment). This was actually for a media engine reset I ran into while looking into the feature requested in that issue, so it probably makes more sense to continue discussions there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batch_addrs[0] (uint64_t) was cast through uintptr_t before assignment to exec.address (__u64). On 32-bit builds this truncates GPU VAs above 4GB, causing the kernel to reject or fault the dispatch and reset the media engine.
Pass batch_addrs[0] directly. For the array pointer branch, use the standard (uint64_t)(uintptr_t) idiom.