Skip to content

sst: fix legacy API #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askervin merged 1 commit into from
Jun 1, 2026
Merged

sst: fix legacy API #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/sst/fuzz_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ func FuzzClosSetup(f *testing.F) {
if err != nil {
t.Fatalf("failed to get package info: %v", err)
}
if !cmp.Equal(updated[pkg].ClosStatus[clos], *expectedInfo) {
t.Errorf("CLOS not configured correctly, expected %v, got %v", expectedInfo, updated[pkg].ClosStatus[clos])
if !cmp.Equal(updated[pkg].ClosInfo[clos], *expectedInfo) {
t.Errorf("CLOS not configured correctly, expected %v, got %v", expectedInfo, updated[pkg].ClosInfo[clos])
}
})
}
6 changes: 3 additions & 3 deletions pkg/sst/legacy_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ type SstPackageInfo struct {
TFSupported bool
TFEnabled bool

ClosStatus [NumClos]SstClosInfo
ClosInfo [NumClos]SstClosInfo
ClosCPUInfo ClosCPUSet
}

Expand Down Expand Up @@ -318,7 +318,7 @@ func ClosSetup(info *SstPackageInfo, clos int, closInfo *SstClosInfo) error {
return fmt.Errorf("invalid value %d for proportionalPriority", closInfo.ProportionalPriority)
}

info.ClosStatus[clos] = *closInfo
info.ClosInfo[clos] = *closInfo

closConfig := ClosConfig{
ProportionalPriority: closInfo.ProportionalPriority,
Expand Down Expand Up @@ -459,7 +459,7 @@ func statusFromPackage(pkg *cpuPackageInfo, pi *PackageStatus) (*SstPackageInfo,
CPSupported: primary.CP.Supported,
CPEnabled: primary.CP.Enabled,
CPPriority: primary.CP.Priority,
ClosStatus: closInfos,
ClosInfo: closInfos,
ClosCPUInfo: make(ClosCPUSet),
}
if primary.BF.Cores != nil {
Expand Down