sst: add detailed info API by marquiz · Pull Request #188 · intel/goresctrl

marquiz · 2026-05-27T17:47:06Z

Add API to query information about TDP levels. This patch implements a very limited set of data, only basic info on SST-BF and SST-TF. Can be extended on future PRs.

Also implements a new info subcommand for the sst example cli.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

kad · 2026-05-29T10:54:33Z

 		Clos: closInfos,
 	}
-	if control.BFSupported && bfCores != nil {
-		punit.BF.Cores = bfCores


Do we have users of BF.Cores anywhere? e.g. in nri policies?
if yes, might be some backward compatible apis?

Good comment. In the new API this is available via the GetPerfLevelInfo() method (BFInfo.HighPriorityCPUs) so the data is there. BUT, I had failed to add this to the legacy API wrapper so there was a bug (in legacy_api.go). This is now fixed.

EDIT: Yes, NRI plugins use this info to determine the cpu priority classes.

kad · 2026-05-29T10:56:39Z

+			var tfBuckets []TFBucketInfo
+			for b := range 8 {
+				if tfData.HPCoreCounts[b] == 0 {
+					break


continue instead of break? or shall it be also break above for tpmi?

I changed to continue to be in line with TPMI.

kad · 2026-05-29T10:57:07Z

+				}
+			}
+			var tfBuckets []TFBucketInfo
+			for b := range 8 {


This range, maybe declare constant?

Argh, ugly. Change to use range instead

kad · 2026-05-29T10:59:00Z

 }
+
+// PerfLevelGetInfo reads detailed data for one SST-PP performance level.
+func PerfLevelGetInfo(socketID, punitID uint8, level int) (isst.PerfLevelDataInfo, error) {


Umm, yes, remnant of a a version with more detailed info (still WIP, I'll probably submit at some point later on as a separate PR). Dropped

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pkg/sst/isst/types_msr_amd64.go: Language not supported

marquiz · 2026-05-29T19:37:44Z

+	lo, err := BFReadCoreMask(cpu, level, 0)
+	if err != nil {
+		return BFInfo{}, err
+	}
+	hi, err := BFReadCoreMask(cpu, level, 1)
+	if err != nil {
+		return BFInfo{}, err
+	}
+	return BFInfo{
+		HighPriorityBaseFreqRatio: int(getBits(p1, 8, 15)),
+		LowPriorityBaseFreqRatio:  int(getBits(p1, 0, 7)),
+		CoreMask:                  uint64(lo) | (uint64(hi) << 32),


Our old impl looks like unnecessary "complication". The cpumask is capped to uint64 on the TPMI interface side, too. Also, what we have here matches the intel-speed-select reference tool implementation.

marquiz · 2026-05-29T19:38:08Z

+	lo, err := isst.SendMboxCmd(cpu, isst.CONFIG_TDP, isst.CONFIG_TDP_GET_CORE_MASK, 0, uint32(level))
+	if err != nil {
+		return 0, fmt.Errorf("failed to read level core mask (lo) at level %d: %w", level, err)
+	}
+	hi, err := isst.SendMboxCmd(cpu, isst.CONFIG_TDP, isst.CONFIG_TDP_GET_CORE_MASK, 0, uint32(level|(1<<8)))
+	if err != nil {
+		return 0, fmt.Errorf("failed to read level core mask (hi) at level %d: %w", level, err)
+	}
+	return uint64(lo) | (uint64(hi) << 32), nil


Same here: the cpumask is capped to uint64 on the TPMI interface side, too. Also, what we have here matches the intel-speed-select reference tool implementation.

marquiz · 2026-05-29T19:39:16Z

+	Supported bool `json:"supported"`
+	Enabled   bool `json:"enabled"`


IT's deliberate to drop it within the new API. The old API still has the field and is not changed. In the new API the "Cores" is retrieved with the GetPerfLevelInfo() method.

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.

Files not reviewed (1)

pkg/sst/isst/types_msr_amd64.go: Language not supported

Make them not importable by other projects. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 17 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

pkg/sst/internal/isst/types_msr_amd64.go: Language not supported

Add API to query information about TDP levels. This patch implements a very limited set of data, only basic info on SST-BF and SST-TF. Can be extended on future PRs. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

marquiz · 2026-06-01T09:48:55Z

Updated. Major churn included here is to move the mbox/, tpmi/ and isst/ helper packages under internal/ to make them not importable by other projects (those packages are really only designed for our internal use).

Also addressed copilot's review comments, with some renaming of methods and improving/consolidating error messages.

Copilot

Pull request overview

Copilot reviewed 11 out of 17 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pkg/sst/internal/isst/types_msr_amd64.go: Language not supported

kad

LGTM

askervin

LGTM

marquiz requested review from askervin and kad May 27, 2026 17:47

kad requested a review from Copilot May 29, 2026 07:55

Copilot started reviewing on behalf of kad May 29, 2026 07:55 View session

marquiz force-pushed the devel/sst-info branch 2 times, most recently from b029c74 to 541982b Compare May 29, 2026 08:13

This comment was marked as resolved.

Sign in to view

marquiz force-pushed the devel/sst-info branch from 541982b to 57ad525 Compare May 29, 2026 08:24

kad requested a review from Copilot May 29, 2026 09:07

Copilot started reviewing on behalf of kad May 29, 2026 09:07 View session

marquiz requested review from Copilot and removed request for Copilot May 29, 2026 09:24

Copilot started reviewing on behalf of marquiz May 29, 2026 09:24 View session

This comment was marked as resolved.

Sign in to view

kad requested a review from Copilot May 29, 2026 09:40

This comment was marked as resolved.

Sign in to view

marquiz requested a review from Copilot May 29, 2026 10:01

Copilot AI reviewed May 29, 2026

View reviewed changes

askervin requested a review from Copilot May 29, 2026 10:43

Copilot AI reviewed May 29, 2026

View reviewed changes

kad reviewed May 29, 2026

View reviewed changes

marquiz force-pushed the devel/sst-info branch from 57ad525 to 78a6216 Compare May 29, 2026 12:38

marquiz requested review from Copilot and kad May 29, 2026 12:48

Copilot AI reviewed May 29, 2026

View reviewed changes

marquiz requested a review from Copilot May 29, 2026 16:53

Copilot started reviewing on behalf of marquiz May 29, 2026 16:53 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

marquiz force-pushed the devel/sst-info branch from 78a6216 to 2a94b06 Compare May 29, 2026 19:35

marquiz requested a review from Copilot June 1, 2026 06:48

Copilot started reviewing on behalf of marquiz June 1, 2026 06:48 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/sst/backend.go Outdated

Comment thread pkg/sst/backend.go Outdated

Comment thread pkg/sst/backend.go

Comment thread pkg/sst/backend.go

Comment thread cmd/sst/main.go

Comment thread cmd/sst/main.go

Comment thread pkg/sst/internal/isst/msr.go

sst: move helper packages to internal/

f3eb140

Make them not importable by other projects. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

marquiz force-pushed the devel/sst-info branch from 2a94b06 to 3b2b354 Compare June 1, 2026 09:14

marquiz requested a review from Copilot June 1, 2026 09:29

Copilot started reviewing on behalf of marquiz June 1, 2026 09:30 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/sst/backend.go

Comment thread pkg/sst/backend.go

Comment thread pkg/sst/backend.go

Comment thread pkg/sst/backend.go

Comment thread pkg/sst/backend.go

Comment thread cmd/sst/main.go

marquiz added 2 commits June 1, 2026 12:43

sst: add detailed info API

3f62eff

Add API to query information about TDP levels. This patch implements a very limited set of data, only basic info on SST-BF and SST-TF. Can be extended on future PRs. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

cmd/sst: implement info subcommand

88c6fda

Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>

marquiz force-pushed the devel/sst-info branch from 3b2b354 to 88c6fda Compare June 1, 2026 09:45

marquiz requested a review from Copilot June 1, 2026 09:45

Copilot started reviewing on behalf of marquiz June 1, 2026 09:46 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread pkg/sst/internal/isst/msr.go

kad approved these changes Jun 1, 2026

View reviewed changes

askervin approved these changes Jun 1, 2026

View reviewed changes

askervin merged commit 293d231 into intel:main Jun 1, 2026
6 checks passed

marquiz deleted the devel/sst-info branch June 1, 2026 12:58

		Supported bool `json:"supported"`
		Enabled bool `json:"enabled"`

Conversation

marquiz commented May 27, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marquiz May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marquiz May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marquiz commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kad left a comment

Choose a reason for hiding this comment

Uh oh!

marquiz May 29, 2026 •

edited

Loading

marquiz May 29, 2026 •

edited

Loading