Add fish, PowerShell, and Nushell completion support - #102
Conversation
There was a problem hiding this comment.
💡 Codex Review
Lines 141 to 150 in 6b9a8a1
The commit advertises fish, PowerShell, and Nushell completions and README examples now call ./app completion fish etc., but Parser.Completion still only handles bash and zsh and prints an "Unsupported shell" error for all other values. As a result the public API and CLI entry point cannot emit the new scripts even though the generators exist, so the documented commands will fail. Consider adding branches for the new shells in this switch.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
|
@codex address the problem of 'unsupported shell' being returned for the new shell completion types by the subcommand parser. Add a test that directly tests the triggering of each autocomplete call and verifies the output. |
|
Summary
Testing
|
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e0a4f789748323892f10f75ffc6511