Skip to content

Fixes the BBOX of STAC Resources #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AM1729 merged 2 commits into from
Jul 23, 2026
Merged

Fixes the BBOX of STAC Resources #311

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34517bc
fixes bbox for stac resources, observing outisde bounds message
AM1729 Jul 23, 2026
0daad81
removes logical without a time
AM1729 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions adapters/klab.ogc/src/main/java/org/integratedmodelling/klab/stac/STACCollectionParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,34 @@ public static String readCollectionId(JSONObject collection) {
* @return geometry
*/
public static IGeometry readGeometry(JSONObject collection, boolean featureOnly) {
GeometryBuilder gBuilder = Geometry.builder();

GeometryBuilder gBuilder = Geometry.builder();

JSONObject extent = collection.getJSONObject("extent");
List bbox = extent.getJSONObject("spatial").getJSONArray("bbox").getJSONArray(0).toList();
gBuilder.space().boundingBox(Double.valueOf(bbox.get(0).toString()), Double.valueOf(bbox.get(1).toString()),
Double.valueOf(bbox.get(2).toString()), Double.valueOf(bbox.get(3).toString()));

List interval = extent.getJSONObject("temporal").getJSONArray("interval").getJSONArray(0).toList();
if (interval.get(0) != null) {
gBuilder.time().start(Instant.parse(interval.get(0).toString()).toEpochMilli());
}
if (interval.size() > 1 && interval.get(1) != null) {
gBuilder.time().end(Instant.parse(interval.get(1).toString()).toEpochMilli());
}
gBuilder.space().boundingBox(Double.valueOf(bbox.get(0).toString()), Double.valueOf(bbox.get(2).toString()),
Double.valueOf(bbox.get(1).toString()), Double.valueOf(bbox.get(3).toString())); // In STAC, the geometry obj should necessarily be in WGS84 so it's good

// IMPORTANT: In k.LAB it's minX, maxX, minY, maxY; but in STAC or geoserver the bbox is
// minX, minY, maxX, maxY

// Avoid setting the time since, they get filtered later on

// List interval = extent.getJSONObject("temporal").getJSONArray("interval").getJSONArray(0).toList();
// if (interval.get(0) != null) {
// gBuilder.time().start(Instant.parse(interval.get(0).toString()).toEpochMilli());
// }
// if (interval.size() > 1 && interval.get(1) != null) {
// gBuilder.time().end(Instant.parse(interval.get(1).toString()).toEpochMilli());
// }

//TODO: Figure out a way to know if time would be logical or grid

// TODO find non-ad-hoc cases
if (collection.getString("id").equals("slovak_SK_v5_reference-points_EUNIS2012") || featureOnly) {
return gBuilder.build().withProjection(Projection.DEFAULT_PROJECTION_CODE).withTimeType("logical");
}
return gBuilder.build().withProjection(Projection.DEFAULT_PROJECTION_CODE).withTimeType("grid");
// if (collection.getString("id").equals("slovak_SK_v5_reference-points_EUNIS2012") || featureOnly) {
// return gBuilder.build().withProjection(Projection.DEFAULT_PROJECTION_CODE).withTimeType("logical");
// }
return gBuilder.build().withProjection(Projection.DEFAULT_PROJECTION_CODE);
}

private static JSONObject findAsset(JSONObject assets, String assetId, Predicate<JSONObject> predicate) {
Expand Down
Loading