Skip to content

test(serializers): Move benchmark test-data to test-only location - #19504

Merged
srebhan merged 2 commits into
influxdata:masterfrom
srebhan:cleanup
Aug 21, 2026
Merged

test(serializers): Move benchmark test-data to test-only location#19504
srebhan merged 2 commits into
influxdata:masterfrom
srebhan:cleanup

Conversation

@srebhan

@srebhan srebhan commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

This PR moves the test-data generating function from plugins/serializers to testutil/serializers in order to prevent leaking this function (and testing packages) to production code. Instead the data now lives in a location that is only included in test-code and thus the go-compiler will be able to exclude it from the released binary efficiently.

Checklist

Related issues

@telegraf-tiger telegraf-tiger Bot added the test label Aug 21, 2026
@skartikey skartikey changed the title test(serializers): Nove benchmark test-data to test-only location test(serializers): Move benchmark test-data to test-only location Aug 21, 2026

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks! Just one minor comment.

Comment thread testutil/serializers/benchmark_data.go Outdated
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. plugin/serializer labels Aug 21, 2026
@srebhan
srebhan requested a review from skartikey August 21, 2026 14:02

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks!

@telegraf-tiger

Copy link
Copy Markdown
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 6.53 % for linux amd64 (new size: 328.4 MB, nightly size 308.2 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan
srebhan merged commit 858a0ad into influxdata:master Aug 21, 2026
27 checks passed
@srebhan
srebhan deleted the cleanup branch August 21, 2026 15:54
@github-actions github-actions Bot added this to the v1.40.0 milestone Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants