Skip to content

test(inputs.libvirt): Merge mocking into test file - #19496

Merged
srebhan merged 2 commits into
influxdata:masterfrom
srebhan:tests_fix
Aug 21, 2026
Merged

test(inputs.libvirt): Merge mocking into test file#19496
srebhan merged 2 commits into
influxdata:masterfrom
srebhan:tests_fix

Conversation

@srebhan

@srebhan srebhan commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

This PR moves the libvirt mocking into the test file to prevent testing code to leak into the released binary.

Checklist

Related issues

resolves #19374

@telegraf-tiger telegraf-tiger Bot added plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins test labels Aug 19, 2026
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 19, 2026
@skartikey

Copy link
Copy Markdown
Contributor

@srebhan make check-deps is failing lint-linux: now that nothing outside the tests pulls testify in, the github.com/stretchr/objx and github.com/stretchr/testify entries in docs/LICENSE_OF_DEPENDENCIES.md need to go.

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan perfect!

@telegraf-tiger

Copy link
Copy Markdown
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 6.53 % for linux amd64 (new size: 328.4 MB, nightly size 308.2 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan
srebhan merged commit 88f3ff7 into influxdata:master Aug 21, 2026
27 checks passed
@srebhan
srebhan deleted the tests_fix branch August 21, 2026 15:54
@github-actions github-actions Bot added this to the v1.40.0 milestone Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Move package-local mock files to _test.go so testify stays out of the binary

2 participants