fix: prevent leaderboard rank numbers flashing wrong positions on initial load#556
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: prevent leaderboard rank numbers flashing wrong positions on initial load#556saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
…tial load Wait for Firestore server data before hiding loading state. Cache data may be unsorted/partial, causing rank numbers to flash incorrect values before jumping to correct positions. Uses snapshot.metadata.fromCache with a 5s safety timeout as fallback for offline scenarios. Closes indresh404#552
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #552
The leaderboard uses Firestore
onSnapshotwhich fires twice on page load:Previously, the loading state was removed after the first callback, causing the rank numbers to display incorrect positions for a brief moment before jumping to the correct order.
Change
snapshot.metadata.fromCache === false)Testing