fix: ensure boolean status is correctly converted to string in rawatInap method#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates PCare service helpers to ensure request URLs and endpoints match the expected BPJS API formats, including a fix for boolean-to-string conversion and adding a missing update operation for kunjungan.
Changes:
- Convert
rawatInapboolean status into"true"/"false"strings before appending to thestatuspulangfeature path. - Add an
update()method toKunjunganthat performs a PUT tokunjungan/v1and returns the decoded response.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/PCare/StatusPulang.php | Ensures rawatInap status is appended as "true"/"false" instead of PHP’s default boolean string casting. |
| src/PCare/Kunjungan.php | Adds a PUT-based update() operation for the kunjungan/v1 endpoint to complement the existing store(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| public function rawatInap($status = true) | ||
| { | ||
| $status = $status ? 'true' : 'false'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.