Skip to content

Prepare for indexmap 2.0 - #219

Merged
cuviper merged 16 commits into
indexmap-rs:masterfrom
cuviper:v2
Mar 29, 2022
Merged

Prepare for indexmap 2.0#219
cuviper merged 16 commits into
indexmap-rs:masterfrom
cuviper:v2

Conversation

@cuviper

@cuviper cuviper commented Feb 9, 2022

Copy link
Copy Markdown
Member

Of the list in #135, the ones addressed here are:

  • Increase MSRV to 1.56
  • Always use an explicit feature for std
  • Make get_index_mut return &K

I also added a few new features:

  • Add MutableKeys::get_index_mut2
  • impl Debug for IterMut and ValuesMut
  • Add shrink_to

@cuviper

cuviper commented Feb 9, 2022

Copy link
Copy Markdown
Member Author

Regarding other points from #135:

  • Change the default hasher -- I think we should still consider this if we choose something no_std and hide it in a newtype. I don't think it's necessary though, especially now that we have a cleaner std story.
  • Parameterize the index type -- that would be Parameterize the index type of maps and sets #147, and I would like to see that now, or else abandon the idea. It can be rebased and merged after this PR though.
  • Maybe change the default remove()? I think we're ok as-is.
  • Consider ordered PartialEq + Eq -- now is the time to talk about it, but I'm inclined to leave this alone. But we could merge Add dynamically-sized slices of maps and sets #177 which has that behavior in slices.

@cuviper
cuviper requested a review from bluss February 9, 2022 18:40
@cuviper cuviper mentioned this pull request Mar 22, 2022
@bluss

bluss commented Mar 29, 2022

Copy link
Copy Markdown
Member

Awesome. Thanks a lot, and sorry for the long delay

@cuviper

cuviper commented Mar 29, 2022

Copy link
Copy Markdown
Member Author

Alright, I've rebased, and I pushed an indexmap-1.x branch for older stable work. Let's merge and see about those other features separately!

@cuviper
cuviper merged commit a31003c into indexmap-rs:master Mar 29, 2022
@cuviper
cuviper deleted the v2 branch July 18, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants