fix: topic session isolation + security hardening#91
Merged
royosherove merged 1 commit intomainfrom May 10, 2026
Merged
Conversation
Fixes from Codex full review: 1. HIGH: Topic sessions now scoped per chat — thread ID is 'topic:<chatId>:<topicName>' not just 'topic:<topicName>'. Two users with same topic name get separate sessions. 2. HIGH: listTopics() now filters by calling chat's ID prefix. Users only see their own topics. 3. MEDIUM: /topic rejected in groups with helpful message (groups should use Telegram forum topics instead). 4. MEDIUM: Atomic persistence — temp file + rename pattern prevents corruption on crash. 403 tests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex review fixes: chat-scoped topic IDs, scoped listing, group rejection, atomic persistence. 403 tests green.