Skip to content

fix: decouple BedrockRegion from deploy region #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royosherove merged 1 commit into from
May 8, 2026
Merged

fix: decouple BedrockRegion from deploy region #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,14 +1966,23 @@ pack_default_model() {

# Populate PARAM_VALUES from user config (call after collect_config)
build_deploy_params() {
# Bedrock region: use us-east-1 by default (widest model availability, cross-region inference)
# Only override if the deploy region is itself a supported Bedrock region
local bedrock_allowed="us-east-1 us-west-2 eu-west-1 eu-central-1 eu-north-1 ap-northeast-1"
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include ap-southeast-1 in Bedrock region allowlist

The new bedrock_allowed gate omits ap-southeast-1, even though both deploy targets treat it as a valid Bedrock region (deploy/cloudformation/template.yaml BedrockRegion.AllowedValues and deploy/terraform/variables.tf validation). In that region, build_deploy_params now forces BEDROCK_REGION=us-east-1, which introduces an unintended cross-region override and can cause runtime/model-access failures for accounts that only enabled Bedrock access in ap-southeast-1; this is a regression from the previous BedrockRegion=$DEPLOY_REGION behavior for supported regions.

Useful? React with 👍 / 👎.

if [[ " $bedrock_allowed " == *" $DEPLOY_REGION "* ]]; then
BEDROCK_REGION="$DEPLOY_REGION"
else
BEDROCK_REGION="us-east-1"
fi

PARAM_VALUES=(
"$ENV_NAME"
"$PACK_NAME"
"$PROFILE_NAME"
"$INSTANCE_TYPE"
"${DEFAULT_MODEL:-$(pack_default_model "$PACK_NAME")}"
"bedrock"
"$DEPLOY_REGION"
"$BEDROCK_REGION"
"$LOKI_WATERMARK"
"false"
"$SECURITY_HUB"
Expand Down Expand Up @@ -2061,6 +2070,7 @@ show_summary() {
summary+="Profile ${PROFILE_NAME}\n"
summary+="Instance ${INSTANCE_TYPE}\n"
summary+="Region ${DEPLOY_REGION}\n"
[[ "$BEDROCK_REGION" != "$DEPLOY_REGION" ]] && summary+="Bedrock ${BEDROCK_REGION} (cross-region inference)\n"
[[ -n "${EXISTING_VPC_ID:-}" ]] && summary+="VPC reuse ${EXISTING_VPC_ID}\n"
summary+="Security ${security_summary}\n"
summary+="Environment ${ENV_NAME}"
Expand Down
Loading