Skip to content

update NetInfo dependency#343

Open
pkcwong wants to merge 1 commit into
inProgress-team:masterfrom
pkcwong:master
Open

update NetInfo dependency#343
pkcwong wants to merge 1 commit into
inProgress-team:masterfrom
pkcwong:master

Conversation

@pkcwong

@pkcwong pkcwong commented Jun 21, 2019

Copy link
Copy Markdown

Fix for #342

Changed NetInfo dependency from react-native to @react-native-community as suggested in React Native docs.

https://facebook.github.io/react-native/docs/netinfo.html

@ghost

ghost commented Jul 12, 2019

Copy link
Copy Markdown

Please merge this PR.
Facing NetInfo issue on RN 0.60

@pkcwong

pkcwong commented Jul 12, 2019

Copy link
Copy Markdown
Author

Same issue goes for AsyncStorage as well, I think a few other packages too

@jakeols

jakeols commented Jul 17, 2019

Copy link
Copy Markdown

Anything else that can be done for this? Getting the error undefined is not an object (evaluating '_reactNative.NetInfo.isConnected') relating to this.

@pkcwong

pkcwong commented Jul 17, 2019

Copy link
Copy Markdown
Author

My workaround now is to clone this entire repo, then add the directory as an Npm dependency.
Here is an example.
https://github.com/pkcwong/react-native-meteor-starter/tree/master/libs/react-native-meteor
Note I cloned this repo into a /libs directory in my project. Then in my package.json I do this.

"react-native-meteor": "file:./libs/react-native-meteor"

https://github.com/pkcwong/react-native-meteor-starter/blob/master/package.json#L13

You can then fix the dependencies yourself.

@ma-lemire

Copy link
Copy Markdown

Plz merge this fix !

@pkcwong

pkcwong commented Aug 1, 2019

Copy link
Copy Markdown
Author

@ma-lemire Last commit to this repo is nearly a year ago. You can use this workaround for now.
#343 (comment)

@ma-lemire

Copy link
Copy Markdown

@pkcwong Thx man works well ! i just add async-storage with @react-native-community/async-storage

@JonahGroendal

Copy link
Copy Markdown

@charpeni could you merge this pls?

@JonahGroendal

Copy link
Copy Markdown

downgrading react-native to 0.59.10 works as an alternative to #343 (comment)

@wallind

wallind commented Jan 16, 2020

Copy link
Copy Markdown

My team ran into this issue and was able to fix it using the commit in this PR. This is a definitive issue with using React Native versions 0.60.0 and above.

@charpeni please merge this PR into the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants