Skip to content

Make tier 1 blood worms not breathe - #697

Open
XxRaay wants to merge 1 commit into
imperial-space:developfrom
XxRaay:develop
Open

Make tier 1 blood worms not breathe#697
XxRaay wants to merge 1 commit into
imperial-space:developfrom
XxRaay:develop

Conversation

@XxRaay

@XxRaay XxRaay commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

О ПР`е

Тип: tweak

Изменения: Черви т1 теперь не дышат, что-бы при спавне не умирали

Технические детали

Нет

Изменения кода официальных разработчиков

Нет

Summary by CodeRabbit

  • Исправления
    • Исправлено поведение червя первого уровня: он больше не использует неподходящие атмосферные и дыхательные характеристики.
    • Червь теперь корректно наследует базовые свойства своего типа.

@github-actions github-actions Bot added Prototypes Изменения добавляет новые прототипы size/Small Насколько сложно будет апстримить labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

В декларации MobWormTier1 сохранено наследование от MobWormBase. Наследование от MobAtmosStandard и MobRespirator удалено.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Заголовок точно описывает основное изменение: MobWormTier1 больше не дышит.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Prototypes/Imperial/XxRaay/worms.yml`:
- Line 94: Update the MobWormTier1 parent definition to retain MobAtmosStandard
while removing only MobRespirator, so ThermalRegulator, Temperature, and
TemperatureDamage remain inherited and the change disables breathing without
altering temperature behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a55c4cca-4843-4f06-9dd8-e2175de2993c

📥 Commits

Reviewing files that changed from the base of the PR and between 8b49254 and 2e751e0.

📒 Files selected for processing (1)
  • Resources/Prototypes/Imperial/XxRaay/worms.yml

- MobWormBase
- MobAtmosStandard
- MobRespirator
parent: MobWormBase

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Сохраните MobAtmosStandard, если цель PR — отключить только дыхание.

MobAtmosStandard добавляет ThermalRegulator, Temperature и TemperatureDamage (Resources/Prototypes/Entities/Mobs/base.yml:196-216). После изменения MobWormTier1 теряет эти компоненты, потому что они не объявлены явно. Это меняет температурный урон и выживание червя. Верните MobAtmosStandard в parent и удалите только MobRespirator, либо добавьте эквивалентные компоненты явно.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Prototypes/Imperial/XxRaay/worms.yml` at line 94, Update the
MobWormTier1 parent definition to retain MobAtmosStandard while removing only
MobRespirator, so ThermalRegulator, Temperature, and TemperatureDamage remain
inherited and the change disables breathing without altering temperature
behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Prototypes Изменения добавляет новые прототипы size/Small Насколько сложно будет апстримить

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant