Fix stale texture cleanup on build - #9
Merged
Merged
Conversation
The CopyToMods build target was incremental — it copied new files but never removed old ones. Stale 16x16 texture PNGs from a previous build persisted in the deploy directory, causing TextureGenerator to skip runtime generation of proper 32x32 textures. Item icons appeared blank. Adding RemoveDir before the asset copy ensures a clean deploy every build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyToModsMSBuild target copies new files but never cleaned old ones, soTextureGenerator.TryGet()found the stale PNGs and skipped 32x32 runtime generation<RemoveDir>for the assets directory before the asset copy step in the build, ensuring stale files are always cleanedTest plan
dotnet buildsucceedstextures/dir contains onlyicerinkcreator.png(no stale blade/strap PNGs)🤖 Generated with Claude Code