Don't display "invalid auth" flash message on login page - #9464
Open
michaelchadwick wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
requested changes
Aug 10, 2026
jrjohnson
left a comment
jrjohnson
left a comment
Member
There was a problem hiding this comment.
It's more verbose, but I'd be happier not using the fetch service on the form auth part of the login route than doing this one off string comparison in the fetch service. I don't like the design of the service needing to know about the route, feels backwards.
Contributor
✅ Visual Diff Report — PASSED984 images compared: 984 identical Download the results. |
stopfstedt
previously approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#7344