Course->Publish missing details button bugfix - #9463
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Visual Diff Report — PASSED984 images compared: 984 identical Download the results. |
jrjohnson
left a comment
There was a problem hiding this comment.
Does detailsCollapseControl need to be a query parameter at all? Wouldn't it be safer to make this a get showCollapseControl on the controller or root component and then decide based on the current route?
On second thought, it does not! Refactored to make it a controller method instead, and it's much cleaner. Thank you! |
dartajax
left a comment
There was a problem hiding this comment.
As far as the hiding of the "Hide Details" button is concerned, this fix seems good to me. "Show Details" is not actually applicable in this particular situation since the screen is already set to show details even if hide details was the state the screen was in before doing the publication. That would be a different issue anyway.
360b27f to
42cf64c
Compare
…sible detailsCollapseControl
… and cleaned up code
42cf64c to
055cebb
Compare
Fixes ilios/ilios#7340
Fixes bug where after publishing a course the "Hide/Show Details" button was hidden.