Skip to content

Course->Publish missing details button bugfix - #9463

Merged
michaelchadwick merged 5 commits into
ilios:masterfrom
michaelchadwick:frontend-7340-publish-course-missing-details-button-bugfix
Aug 11, 2026
Merged

Course->Publish missing details button bugfix#9463
michaelchadwick merged 5 commits into
ilios:masterfrom
michaelchadwick:frontend-7340-publish-course-missing-details-button-bugfix

Conversation

@michaelchadwick

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#7340

Fixes bug where after publishing a course the "Hide/Show Details" button was hidden.

@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 055cebb
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a7b8203e6ac57000851aedf
😎 Deploy Preview https://deploy-preview-9463--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

✅ Visual Diff Report — PASSED

984 images compared: 984 identical

Download the results.

@jrjohnson jrjohnson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does detailsCollapseControl need to be a query parameter at all? Wouldn't it be safer to make this a get showCollapseControl on the controller or root component and then decide based on the current route?

@michaelchadwick
michaelchadwick marked this pull request as draft August 10, 2026 23:04
@michaelchadwick
michaelchadwick marked this pull request as ready for review August 10, 2026 23:34
@michaelchadwick

Copy link
Copy Markdown
Contributor Author

Does detailsCollapseControl need to be a query parameter at all? Wouldn't it be safer to make this a get showCollapseControl on the controller or root component and then decide based on the current route?

On second thought, it does not! Refactored to make it a controller method instead, and it's much cleaner. Thank you!

@jrjohnson
jrjohnson removed the request for review from stopfstedt August 10, 2026 23:44

@dartajax dartajax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the hiding of the "Hide Details" button is concerned, this fix seems good to me. "Show Details" is not actually applicable in this particular situation since the screen is already set to show details even if hide details was the state the screen was in before doing the publication. That would be a different issue anyway.

@michaelchadwick
michaelchadwick force-pushed the frontend-7340-publish-course-missing-details-button-bugfix branch from 360b27f to 42cf64c Compare August 11, 2026 20:07
@michaelchadwick
michaelchadwick force-pushed the frontend-7340-publish-course-missing-details-button-bugfix branch from 42cf64c to 055cebb Compare August 11, 2026 20:11
@michaelchadwick
michaelchadwick merged commit a09b09e into ilios:master Aug 11, 2026
48 checks passed
@michaelchadwick
michaelchadwick deleted the frontend-7340-publish-course-missing-details-button-bugfix branch August 11, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide Details Is Missing - Course Page - Publish with "Missing Items" Route

3 participants