Skip to content

Truncate overly long event session descriptions - #9429

Open
michaelchadwick wants to merge 7 commits into
ilios:masterfrom
michaelchadwick:frontend-6656-dash-fade-long-event-text
Open

Truncate overly long event session descriptions#9429
michaelchadwick wants to merge 7 commits into
ilios:masterfrom
michaelchadwick:frontend-6656-dash-fade-long-event-text

Conversation

@michaelchadwick

@michaelchadwick michaelchadwick commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes ilios/ilios#6656

After much work trying to get TruncateText's "character count" algo to work more like FadeText's "vertical space" algo, I gave up as I was essentially turning one component into the other for no reason.

In the end, just putting TruncateText on session descriptions when shown on the WaaG and/or Single Event routes feels like enough. If it's overly tall, it still won't truncate unless the character count is long enough, which feels like an edge cases most of the time.

This also squares up the presentation of session descriptions across WaaG, Single Event, Session, and editing Session, as they were not normalized (mainly in how they displayed lists).

Here's an example of various description "lengths" on the dashboard and how they'd now be handled.
Screenshot 2026-08-06 at 1 15 48 PM

The preview, logged in as dev, also currently has a course with a session and a wacky description to check all this again.

@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit a795c0c
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/6a75093d6979570009b89922
😎 Deploy Preview https://deploy-preview-9429--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

❌ Visual Diff Report — FAILED

984 images compared: 8 different · 976 identical

Details

Differences (8)

File Diff % Notes
desktop-Acceptance _ Dashboard Week at a Glance _ shows all pre work _ .png 0.27%
desktop-Acceptance _ Dashboard Week at a Glance _ shows events _ .png 0.34%
laptop-Acceptance _ Dashboard Week at a Glance _ shows all pre work _ .png 0.25%
laptop-Acceptance _ Dashboard Week at a Glance _ shows events _ .png 0.34%
phone-Acceptance _ Dashboard Week at a Glance _ shows all pre work _ .png 0.58%
phone-Acceptance _ Dashboard Week at a Glance _ shows events _ .png 0.52%
tablet-Acceptance _ Dashboard Week at a Glance _ shows all pre work _ .png 0.38%
tablet-Acceptance _ Dashboard Week at a Glance _ shows events _ .png 0.45%

Download the results.

@michaelchadwick michaelchadwick changed the title Truncate user events with many page breaks on WaaG Truncate/normalize overly tall event descriptions Jul 23, 2026
@michaelchadwick

michaelchadwick commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

NTS: Try combining TruncateText but with the FadeText vertical checking.

@michaelchadwick
michaelchadwick force-pushed the frontend-6656-dash-fade-long-event-text branch from 0950301 to ce53fe3 Compare August 5, 2026 21:49
@michaelchadwick michaelchadwick changed the title Truncate/normalize overly tall event descriptions Truncate overly long event session descriptions Aug 6, 2026
@michaelchadwick
michaelchadwick marked this pull request as ready for review August 6, 2026 22:23
@dartajax

dartajax commented Aug 6, 2026

Copy link
Copy Markdown
Member
image image

@dartajax

dartajax commented Aug 7, 2026

Copy link
Copy Markdown
Member
image

@dartajax

dartajax commented Aug 7, 2026

Copy link
Copy Markdown
Member

I know it's on me to merge this PR but I'm not quite feeling it ... yet.

@dartajax

dartajax commented Aug 7, 2026

Copy link
Copy Markdown
Member

from PR build ...

image

from Netlify ...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This Should Be Truncated or Faded

3 participants