perf: backend storage/admin queries without loading all documents (#2) - #54
Open
cornerblue wants to merge 1 commit into
Open
perf: backend storage/admin queries without loading all documents (#2)#54cornerblue wants to merge 1 commit into
cornerblue wants to merge 1 commit into
Conversation
…ocuments - sumSizeBytesByOwnerId for quota checks (store path) - countByOwner_Id + sum for admin user list (was N+1 load-all-docs) - existsByAdminTrue / countByAdminTrue instead of findAll().stream() Closes iii123iii#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2 (backend speed).
Quota and admin listing were loading every
Documentrow into memory just to sum sizes. That is O(n) entities per request.Changes
DocumentRepository.sumSizeBytesByOwnerId+countByOwner_Idaggregate queriesStorageService.storeuses sum for storage-limit checkAdminService.getAllUsersuses sum/count per user instead offindByOwnerIdOrderByCreatedAtDesc+ streamexistsByAdminTrueinstead offindAll().stream()Test plan
./gradlew testgreen when Java 21 available/opire try
Closes #2