Skip to content

Bump version numbers and fix up warnings - #5

Open
jngls wants to merge 4 commits into
ihciah:masterfrom
jngls:safety-update
Open

Bump version numbers and fix up warnings#5
jngls wants to merge 4 commits into
ihciah:masterfrom
jngls:safety-update

Conversation

@jngls

@jngls jngls commented Jun 14, 2025

Copy link
Copy Markdown
Contributor
  • Bump version numbers to latest
  • Fix up new warnings

Maybe Controversial

I've updated rust edition = "2024" - what do you think?

@ihciah

ihciah commented Jun 15, 2025

Copy link
Copy Markdown
Owner

I've updated rust edition = "2024" - what do you think?

I suggest keeping the status quo. For example, smallvec still uses the 2018 version because upgrading directly may break users. We can consider upgrading in the next major version, but this will still cause users to have to increase their MSRV to upgrade.

@jngls

jngls commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Cool. Yeah that makes sense. Reverted the edition change back to 2021.

@onbjerg

onbjerg commented Aug 18, 2025

Copy link
Copy Markdown

Bump @ihciah, any interest in merging the hashbrown bump? Alternatively, an interest in just using HashMap from std given it's essentially hashbrown anyway?

@ihciah
ihciah force-pushed the master branch 3 times, most recently from 1f19e02 to 825845a Compare December 6, 2025 18:10
@ihciah

ihciah commented Dec 7, 2025

Copy link
Copy Markdown
Owner

Sorry for holding this PR for so long.
I pushed some commits yesterday and reviewed it today. The remaining tasks seem to be adding the unsafe {} and SAFETY: explanations. I believe these will help improve code maintainability. If you’re still up for it, feel free to update the PR and I’ll get it merged.

@ihciah

ihciah commented Dec 7, 2025

Copy link
Copy Markdown
Owner

Alternatively, an interest in just using HashMap from std given it's essentially hashbrown anyway?

@onbjerg Thanks for the ping.

We can switch to std::collections::HashMap, but since the std implementation is already backed by hashbrown, it doesn’t really give us any extra benefit.

More importantly, both this project and hashbrown expose hashbrown::Equivalent, which lets us perform lookups using different key types. That capability is stronger than what the standard library offers, and there’s no indication that std plans to change its API in this area.

So sticking with hashbrown still gives us the flexibility we rely on.

@jngls

jngls commented Dec 7, 2025

Copy link
Copy Markdown
Contributor Author

Yeah still up for it. Most likely tomorrow as I have to wind down now. Cheers!

@ihciah
ihciah force-pushed the master branch 2 times, most recently from e1c84f3 to 93d2647 Compare December 9, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants