feat(mappings): false or empty string to disable mappings#192
Open
Kaiser-Yang wants to merge 1 commit into
Open
feat(mappings): false or empty string to disable mappings#192Kaiser-Yang wants to merge 1 commit into
Kaiser-Yang wants to merge 1 commit into
Conversation
Owner
|
This can be achieved with empty tables. Why should we offer alternatives? |
Author
yeah, you are right. I just forgot this. But this PR seems not too bad. |
Owner
I'll update the docs to make this clearer
If we were to allow the usage of booleans as a shorthand for disabling, we'd also have to update the validation from |
igorlfs
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.