Keep fans when closed on AC power#12
Open
nsd97 wants to merge 1 commit into
Open
Conversation
Honor Keep Fans When Closed on Power for willSleep so lid close does not force fans back to auto after a keep decision. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Keep Fans When Closed on Power (default off): on AC, leave fans under app control through display sleep / lock /
willSleepso lid-close clamshell does not force fans back to auto.Closes #11.
Context
pmset/ private clamshell SPI), battery lid-close beyond existing Keep Fans on Screen Sleep, Ultra / helper changesWhat changed
DisplaySleepFanPolicy—keepClosedOnPower && onAC→ keep; else fall back tokeepOnScreenSleepPowerSource.isOnACvia IOPSFanMonitoruses the same policy for screen sleep, screen lock, andwillSleep(lid close often posts willSleep after screensDidSleep; resetting there was undoing keep)Review guide
Start at:
ChillMac/Fan/DisplaySleepFanPolicy.swift→ChillMac/Fan/FanMonitor.swift(handleSleep/handleScreenSleep/handleScreenLocked) →ChillMac/Views/SettingsView.swift(Fan Control row)How to test
xcodegen generate && xcodebuild -project ChillMac.xcodeproj -scheme ChillMac buildChecklist
xcodegen generate && xcodebuild -scheme ChillMac build)main(no test target yet; policy is pure and covered on the fork harness)Made with Cursor