Some fixes#1
Open
blaix wants to merge 45 commits into
Open
Conversation
For using this gem without rails.
We need Hash.to_xml in addition to the String inflections, so just go ahead and pull in all of core_ext.
Owner
|
These changes all look great--I'll work in pulling them in (can't do an automatic merge for some reason) as soon as I have a spare moment. Thanks! |
Instead of passing an explicit parameter for the old pass phrase, accept a :PassPhrase option or read one from rails config.
Author
|
I've been adding a lot functionality really quickly. It's begging for a refactor but haven't had time yet. Feel free to wait if you don't want to pull in lots of not so pretty codes. |
Owner
|
Just drop me a line as soon as you everything's refactored and I'll take a look and most likely pull everything in. Thanks for all the work! |
Author
|
I've done some refactoring/cleanup. Probably won't be doing any more major refactoring any time soon. I'll be adding support for shipping insurance and carrier pickup hopefully by the end of the day. |
Also includes a revamp of the integration tests and a new task to run unit and integration specs.
Instead of returning an inspected HTTParty response object, return something useful: the actual body of the response from Endicia (with image data stripped for readability).
Added support for MailpieceDimenions (Length, Width, Height) and ImageResolution.
|
What's the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few fixes I thought you might be interested in.