Skip to content

730/mobile compact view#752

Merged
TheAbubakrAbu merged 6 commits into
devfrom
730/mobile-compact-view
Jun 28, 2026
Merged

730/mobile compact view#752
TheAbubakrAbu merged 6 commits into
devfrom
730/mobile-compact-view

Conversation

@kelvinmt456

Copy link
Copy Markdown
Contributor

Summary

Fixed Compact Mobile Restaurant cards to match to the figma.

Changes

  • Changed compact mobile card layout to be in rows of two
  • Changed compact mobile card info to show less information

Testing Instructions

  • Open PeterPlate on mobile, open either of the dining halls, and change to compact view.

Closes #730

@kelvinmt456 kelvinmt456 temporarily deployed to staging-752 May 26, 2026 23:59 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-752 May 26, 2026 23:59 Inactive

@TheAbubakrAbu TheAbubakrAbu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, nice job!

One small thing I noticed (though it's not related to your changes): the favorite heart is currently aligned against the entire content column, so it takes up horizontal space from the dish title, rating, and description. As a result, many dish names get truncated with "..." earlier than necessary, especially on mobile.

In the Figma, the heart is aligned just with the description/content area rather than the full card, which allows the title to use more of the available width. Since you're already working on the compact layout, would you mind adjusting the heart positioning to better match the Figma?

This wasn't very noticeable before, but now that the compact view displays more cards per row (which is great and much closer to the Figma), the current heart positioning causes titles to truncate significantly earlier (especially on mobile). Moving it should give dish names more room and improve readability.

It might also be worth slightly reducing the padding/gap in compact mode if possible, but the heart positioning is the main thing I'd like to see addressed.

@TheAbubakrAbu TheAbubakrAbu temporarily deployed to staging-752 June 28, 2026 21:23 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-752 June 28, 2026 21:24 Inactive
@TheAbubakrAbu TheAbubakrAbu temporarily deployed to staging-752 June 28, 2026 22:21 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-752 June 28, 2026 22:22 Inactive
@TheAbubakrAbu TheAbubakrAbu merged commit 0d84cfb into dev Jun 28, 2026
2 checks passed
@TheAbubakrAbu TheAbubakrAbu deleted the 730/mobile-compact-view branch June 28, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants