Skip to content

Unsuitable Meal Card Update#751

Merged
TheAbubakrAbu merged 3 commits into
devfrom
735/unsuitable-meal-card
Jun 28, 2026
Merged

Unsuitable Meal Card Update#751
TheAbubakrAbu merged 3 commits into
devfrom
735/unsuitable-meal-card

Conversation

@samikabhatkar-web

@samikabhatkar-web samikabhatkar-web commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added an amber tint to food cards that conflict with a user's dietary preferences or allergies (this replaces the original "grayed" out effect which used the "opacity-70" class.
  • I had to do this through the sx props instead of a Tailwind class. This is because MUI takes preference for component styling from CSS over Tailwind classes, so the Tailwind background color would be overridden if I implemented it that way.
    "rgba(245, 158, 11, 0.2)) instead of Tailwind's bg-amber-500/20"

Changes

  • Updated food-card.tsx and popular-dish-card.tsx

Testing Instructions

  • Set any kind of preferences (allergies, dietary restrictions, etc) and ensure that the food card returns "orange-grayed out".
Screenshot 2026-05-26 at 2 51 42 PM

Closes #735

@samikabhatkar-web samikabhatkar-web temporarily deployed to staging-751 May 26, 2026 21:55 — with GitHub Actions Inactive
@samikabhatkar-web samikabhatkar-web linked an issue May 26, 2026 that may be closed by this pull request
@github-actions github-actions Bot temporarily deployed to staging-751 May 26, 2026 21:56 Inactive

@TheAbubakrAbu TheAbubakrAbu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, nice job!

However, I noticed two small differences between this and the Figma:

  • For light mode the tint is perfect. Nice job. But for dark mode there is a different tint which is: rgba(255, 183, 103, 0.21).

  • When you use opacity: 0.7 to the entire card, it makes the text, icons, and ratings look much more faded than in the design as in the Figma, the background is tinted, but the content remains readable and doesn't have opacity.

Nice job though!

@TheAbubakrAbu TheAbubakrAbu temporarily deployed to staging-751 June 28, 2026 22:50 — with GitHub Actions Inactive
@github-actions github-actions Bot temporarily deployed to staging-751 June 28, 2026 22:50 Inactive
@TheAbubakrAbu TheAbubakrAbu merged commit 570079d into dev Jun 28, 2026
2 checks passed
@TheAbubakrAbu TheAbubakrAbu deleted the 735/unsuitable-meal-card branch June 28, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsuitable Meal Card Update

2 participants