Merged
Conversation
thehrh
requested changes
Mar 11, 2026
Collaborator
thehrh
left a comment
There was a problem hiding this comment.
Just a handful of small remarks to address.
It will be important to adapt and improve (where necessary) the two notebook tutorials on stage modes and eventwise information in an upcoming PR.
thehrh
approved these changes
Apr 16, 2026
Collaborator
thehrh
left a comment
There was a problem hiding this comment.
I just fixed the one outstanding review comment. Looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the regularized output binning from the hist stage in the snowstorm hist stage speeds up the latter's computation.
It is important to enforce the apply modes of the different stages (especially the hist stage) to be the same as the output binning because re-binning is not currently supported by PISA. In principle, having a different hist stage apply mode and output binning would be possible and produce the correct results. However, it would not make sense to bin the events in the hist stage just to re-bin them immediately in order to obtain the output map.