Skip to content

Output binning#914

Merged
thehrh merged 16 commits intomasterfrom
output_binning
Apr 16, 2026
Merged

Output binning#914
thehrh merged 16 commits intomasterfrom
output_binning

Conversation

@JanWeldert
Copy link
Copy Markdown
Collaborator

@JanWeldert JanWeldert commented Mar 6, 2026

  • Add global auxiliary data dict to container set, to make it possible to share keys between different containers. This can be used to share the output binning and regularized output binning.
  • Check now if the output binning is the same as the apply mode of the hist stage(s).
  • hist and snowstorm_hist stage can have apply_mode = None. In that case they will directly take the output binning.

Using the regularized output binning from the hist stage in the snowstorm hist stage speeds up the latter's computation.

It is important to enforce the apply modes of the different stages (especially the hist stage) to be the same as the output binning because re-binning is not currently supported by PISA. In principle, having a different hist stage apply mode and output binning would be possible and produce the correct results. However, it would not make sense to bin the events in the hist stage just to re-bin them immediately in order to obtain the output map.

@JanWeldert JanWeldert requested a review from thehrh March 6, 2026 12:44
Copy link
Copy Markdown
Collaborator

@thehrh thehrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a handful of small remarks to address.

It will be important to adapt and improve (where necessary) the two notebook tutorials on stage modes and eventwise information in an upcoming PR.

Comment thread pisa/stages/cont_sys/snowstorm_hist.py
Comment thread pisa/stages/cont_sys/snowstorm_hist.py
Comment thread pisa/stages/utils/hist.py Outdated
Comment thread pisa_examples/resources/settings/pipeline/example.cfg
Comment thread pisa_examples/resources/settings/pipeline/fast_example.cfg
Copy link
Copy Markdown
Collaborator

@thehrh thehrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed the one outstanding review comment. Looks good to me now.

@thehrh thehrh added this to the 4.3 milestone Apr 16, 2026
@thehrh thehrh merged commit 6df2f9a into master Apr 16, 2026
@thehrh thehrh deleted the output_binning branch April 16, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants