[patch] Remove the rsl kubernetes secret creation and remove rls_url and rsl_org_id prarams#456
Open
Bhautik-Vala wants to merge 13 commits into
Open
[patch] Remove the rsl kubernetes secret creation and remove rls_url and rsl_org_id prarams#456Bhautik-Vala wants to merge 13 commits into
Bhautik-Vala wants to merge 13 commits into
Conversation
added 6 commits
May 6, 2026 15:32
Bhautik-Vala
changed the title
Bhautik-Vala
changed the title
jasmin-30
reviewed
May 14, 2026
| url: "{{ .Values.slscfg_url }}" | ||
| secretName: "{{ .Values.tenantNamespace }}----sls-secret" | ||
| ca: "{{ .Values.slscfg_ca_b64enc }}" | ||
| {{- if .Values.rsl_ca_crt }} |
Contributor
There was a problem hiding this comment.
This will add empty ca field even when .Values.rsl_ca_crt is empty. Can we improve condition to add only when it is not empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: MASAIB-2257
Description:
Update gitops helm chart for remove the rsl secret ( kubernetes secret ) creation as this is handled by aiservice operator and also remove the rsl related params - only rls_ca_crt will retain.
Testing:
Testing was done by deployment of aiservice through gitops.