Skip to content

[minor] Add rhoai support to gitops repository#440

Open
Divyesh-Khokhar wants to merge 51 commits into
mainfrom
MASAIB-2112
Open

[minor] Add rhoai support to gitops repository#440
Divyesh-Khokhar wants to merge 51 commits into
mainfrom
MASAIB-2112

Conversation

@Divyesh-Khokhar
Copy link
Copy Markdown

@Divyesh-Khokhar Divyesh-Khokhar commented Apr 14, 2026

Jira

Test result:

  • Installed AIService + ODH:
image

Used install switch to remove odh and install rhoai.

  • ODH remove:
image image
  • Install RHOAI
image image

@Divyesh-Khokhar Divyesh-Khokhar marked this pull request as ready for review April 15, 2026 11:51
Comment thread instance-applications/116-ibm-rhoai/values.yaml Outdated
Comment thread instance-applications/116-ibm-rhoai/values.yaml Outdated
Comment thread root-applications/ibm-aiservice-instance-root/templates/031-ibm-rhoai-app.yaml Outdated
Comment thread root-applications/ibm-aiservice-instance-root/values.yaml Outdated
Comment thread root-applications/ibm-aiservice-instance-root/values.yaml Outdated
@rbinns
Copy link
Copy Markdown
Contributor

rbinns commented Apr 21, 2026

Hi @karol-czarnecki
Need a better description and Test detail added to this PR for review.

@karol-czarnecki karol-czarnecki marked this pull request as draft April 21, 2026 08:19
@karol-czarnecki
Copy link
Copy Markdown

Hi @rbinns
For now we will set this as a draft. We will provide more description and test details when we turn back to review - sorry about that

@Divyesh-Khokhar Divyesh-Khokhar marked this pull request as ready for review May 8, 2026 11:31
Comment thread root-applications/ibm-aiservice-instance-root/values.yaml Outdated
@Divyesh-Khokhar Divyesh-Khokhar requested a review from whitfiea May 11, 2026 08:51
Copy link
Copy Markdown
Member

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the {{- if .Values.application_admin_role }} and {{- if .Values.cluster_admin_role }} conditions to the new rhoai template files? Look at the odh templates for what is set as example. Basically cluster_admin_role for namespaces, subscriptions, cluster level stuff, and application_admin_role for resources in the namespace.

@Divyesh-Khokhar
Copy link
Copy Markdown
Author

Can you add the {{- if .Values.application_admin_role }} and {{- if .Values.cluster_admin_role }} conditions to the new rhoai template files? Look at the odh templates for what is set as example. Basically cluster_admin_role for namespaces, subscriptions, cluster level stuff, and application_admin_role for resources in the namespace.

@whitfiea I've now added role-based conditions to rhoai template files as well.

@whitfiea whitfiea changed the title [patch] GitOps - add rhoai support to gitops repository [minor] Add rhoai support to gitops repository May 11, 2026
@Divyesh-Khokhar Divyesh-Khokhar requested a review from whitfiea May 12, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants