Removing optional IBMCLOUD_VPC_ENDPOINT env#195
Open
prgavali wants to merge 1 commit into
Open
Conversation
Removed IBMCLOUD_VPC_ENDPOINT as it automatically set correctly based on node label https://github.com/confidential-containers/cloud-api-adaptor/blob/main/src/cloud-providers/ibmcloud/provider.go#L105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove IBMCLOUD_VPC_ENDPOINT from documentation to prevent configuration errors. The cloud-api-adaptor now automatically derives and sets the correct VPC Service URL based on the cluster node label topology.kubernetes.io/region
The corresponding code is here --> https://github.com/confidential-containers/cloud-api-adaptor/blob/main/src/cloud-providers/ibmcloud/provider.go#L105
Any other comments?
For reviewers (This section is only for IBMers)
You can't merge pull requests here.
If you don't have permission to close the request, ask for help in the IBM Cloud #docs Slack channel.