Feat/1677#188
Open
conradmugabe wants to merge 7 commits into
Open
Conversation
Adds googleDriveButton, oneDriveButton, and dropboxButton helpers on DatasetsTab. Each takes the Add Resources modal locator and returns the corresponding provider button via getByRole. Used by the upcoming journey 44 cloud picker tests. The CHANGELOG.md changes are an unavoidable side-effect of the pre-commit prettier sweep, which normalizes Markdown bullets from `*` to `-`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Journey 44 (Dataset Cloud Pickers, 3 checkpoints) — asserts the Google Drive, OneDrive, and Dropbox buttons each open their auth popup at the expected provider domain. - Journey 45 (Dataset Upload Types, 8 checkpoints) — uploads a real fixture file for each local-upload resource type (PowerPoint, DOCX, CSV, TXT, Audio, Video, Image, Excel) and asserts the row appears. Bumps summary totals: 44->46 journeys, 43->45 active, 375->386 total checkpoints, 363->374 covered. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds e2e/files/testing_folder/test-data.xlsx — same 11 rows (1 header, 10 data) as the existing test-data.csv fixture, but in .xlsx form so the Excel upload path can be exercised by journey 45. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds journey 44 with 3 tests covering the Add Resources modal's cloud
provider buttons. Each test creates a fresh mentor, opens the Datasets
tab, opens the Add Resources modal, and clicks the provider button.
The test then waits for the third-party SDK to be loaded
(window.gapi / window.OneDrive / window.Dropbox) before clicking — the
Dropbox hook silently no-ops if its SDK isn't ready, so this guard
makes the test deterministic. After the click, page.waitForEvent('popup')
captures the popup and popup.waitForURL polls past the SDK's intermediate
redirect URL until the popup reaches the expected provider domain:
- Google Drive -> accounts.google.com
- OneDrive -> login.microsoftonline.com
- Dropbox -> www.dropbox.com/chooser
If the popup never opens or never reaches the provider domain the test
fails loudly — that is exactly the regression #1677 exists to catch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds journey 45 with 8 tests, one per local-upload resource type (PowerPoint, DOCX, CSV, TXT, Audio, Video, Image, Excel). Each test creates a fresh mentor via createMentorPage.openAndCreate() so the upload is made against a clean dataset list — pre-existing rows from other tests can't mask a missing upload. Tests reuse the existing DatasetsTab.uploadFile(filePath, resourceType) page-object helper (the same one used by journey 20's CSV and Markdown tests) and assert the uploaded filename appears as a row in the dataset list within 15s. A failed upload results in no row and an immediate hard-fail — no try/catch, no `|| true`, no soft assertions. Per-test timeout raised to 200_000 ms to accommodate mentor creation + the slower uploads (video, PowerPoint). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Claude finished @conradmugabe's task —— View job E2E Coverage Review ✅Completed e2e test coverage review for this PR. Todo List
AnalysisChanged files:
Coverage check results: ✅ PASSED
Case determination: Case E - No new page.tsx files and mechanical check PASSED Coverage verification
Decision✅ APPROVED - No new app routes were introduced. All existing coverage is intact and enhanced with new journey tests. |
mamigot
approved these changes
May 12, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact.
Coverage improved: 387 → 398 checkpoints (+11)
- Journey 45: Dataset Cloud Pickers (3 tests)
- Journey 46: Dataset Upload Types (8 tests)
Coverage files are properly updated and all tests are documented correctly.
Member
|
Claude finished @conradmugabe's task —— View job E2E Coverage Review ✅Completed e2e test coverage review for this PR. Todo List
AnalysisChanged files:
Coverage check results: ✅ PASSED
Case determination: Case E - No new page.tsx files and mechanical check PASSED Coverage verification
Decision✅ APPROVED - No new app routes were introduced. All existing coverage is intact and enhanced with new journey tests. |
mamigot
approved these changes
May 15, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact and enhanced with new journey tests.
Coverage improved: 387 → 398 checkpoints (+11)
- Journey 45: Dataset Cloud Pickers (3 tests)
- Journey 46: Dataset Upload Types (8 tests)
Coverage files are properly updated and all tests are documented correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes