S3 for Public Feed Downloads#652
Conversation
This reverts commit 6378872.
We have an internal backlog ticket for that! |
|
Took a look at the code but I'm a bit confused what this does -- does this allow for project-specific s3 deploying? Or is this just an extension to the mtc extension that allows for the use of the existing s3 deployment code |
It allows separate AWS credentials for DT and the MTC extension, so that DT can upload the public feeds elsewhere. This PR does not cover project-specific publishing. |
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Very clean! I'm hoping we do the project-specific html deployment at some point but for now this is a clean solution
Checklist
devbefore they can be merged tomaster)Description
This PR adds support for the use of S3 bucket for public feed hosting, even if S3 is not used for storing feed versions for internal DataTools use.
Behind the scenes, support is added for alternate S3 credentials, region, and bucket for the MTCFeedResource and FeedUpdater that, if specified, override the application's ones: