Skip to content

Replace HolographicTransport with Erasure Coding#810

Draft
iberi22 wants to merge 1 commit into
mainfrom
refactor/erasure-coding-transport-9894423614064503683
Draft

Replace HolographicTransport with Erasure Coding#810
iberi22 wants to merge 1 commit into
mainfrom
refactor/erasure-coding-transport-9894423614064503683

Conversation

@iberi22

@iberi22 iberi22 commented Jun 19, 2026

Copy link
Copy Markdown
Owner

This refactor replaces the legacy, lossy "Holographic Transport" (based on angular transformations) with a robust, lossless Reed-Solomon erasure coding implementation.

Key changes:

  1. Erasure Coding: Introduced ErasureEncoder in synapse-core, providing real redundancy for P2P data transport. By default, it uses 4 data shards and 2 parity shards, allowing for the loss of any 2 shards without data corruption.
  2. Entity Updates: Added ChunkShard to synapse-core::entities to support structured shard management.
  3. Codebase Cleanup: Removed HolographicTransport and HologramCodec adapters which were identified as problematic. Updated relevant mod.rs files and removed orphaned tests/benchmarks.
  4. Infrastructure Fixes: Resolved an issue in SurrealTokenomicsRepository where UserProfile was missing fields (is_validator, total_contributions) in both the Rust struct initialization and the SurrealDB schema, which was causing integration test failures.
  5. Environment Stability: Confirmed that tests pass using --no-default-features to bypass environment-specific issues with the vision feature (specifically v4l2-sys-mit build failures).

Fixes #794


PR created automatically by Jules for task 9894423614064503683 started by @iberi22

- Added `reed-solomon-erasure` dependency to `synapse-core`.
- Implemented `ErasureEncoder` in `synapse-core` for lossless data redundancy.
- Created `ChunkShard` entity to represent individual data/parity shards.
- Deleted legacy `HolographicTransport` and `HologramCodec` from `synapse-infra`.
- Cleaned up broken tests and benchmarks in `synapse-infra` resulting from the removal.
- Fixed `UserProfile` initialization and SurrealDB schema in `tokenomics_adapter` to resolve unrelated test failures.
- Verified lossless reconstruction with 4+2 shards and 2 losses.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8217742-c7bd-4ad3-ba6e-010a80455106

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/erasure-coding-transport-9894423614064503683

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR-3] Reemplazar HolographicTransport por Erasure Coding + Chunk Streaming

1 participant