Replace HolographicTransport with Erasure Coding#810
Conversation
- Added `reed-solomon-erasure` dependency to `synapse-core`. - Implemented `ErasureEncoder` in `synapse-core` for lossless data redundancy. - Created `ChunkShard` entity to represent individual data/parity shards. - Deleted legacy `HolographicTransport` and `HologramCodec` from `synapse-infra`. - Cleaned up broken tests and benchmarks in `synapse-infra` resulting from the removal. - Fixed `UserProfile` initialization and SurrealDB schema in `tokenomics_adapter` to resolve unrelated test failures. - Verified lossless reconstruction with 4+2 shards and 2 losses.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This refactor replaces the legacy, lossy "Holographic Transport" (based on angular transformations) with a robust, lossless Reed-Solomon erasure coding implementation.
Key changes:
ErasureEncoderinsynapse-core, providing real redundancy for P2P data transport. By default, it uses 4 data shards and 2 parity shards, allowing for the loss of any 2 shards without data corruption.ChunkShardtosynapse-core::entitiesto support structured shard management.HolographicTransportandHologramCodecadapters which were identified as problematic. Updated relevantmod.rsfiles and removed orphaned tests/benchmarks.SurrealTokenomicsRepositorywhereUserProfilewas missing fields (is_validator,total_contributions) in both the Rust struct initialization and the SurrealDB schema, which was causing integration test failures.--no-default-featuresto bypass environment-specific issues with thevisionfeature (specificallyv4l2-sys-mitbuild failures).Fixes #794
PR created automatically by Jules for task 9894423614064503683 started by @iberi22