Core Documentation Cleanup & Photonic P2P Alignment#786
Conversation
- Update README.md to reflect the new Decentralized P2P Ingestion Network identity. - Define Synapse as a local daemon with WebSocket (/stream) ingestion. - Highlight PhotonicDhtAdapter and HolographicTransport as core components. - Update Tech Stack to include Axum, Libp2p DHT, and SurrealDB. - Clean up docs/ directory by removing obsolete blockchain and temporary files. - Refine Crystal Logic documentation with current architectural mappings. - Ensure source code remains untouched throughout the documentation update.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's focus to a decentralized P2P ingestion network and photonic transport, updating the README and documentation while purging legacy design documents and mega-issues. The review feedback identifies two documentation issues in CRYSTAL_LOGIC_ARCHITECTURE.md: an undefined dht_key variable in the store_photonic code snippet and duplicate, inconsistent section headers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| pub async fn store_photonic(&self, key: &str, data_str: &str) -> Result<(usize, usize)> { | ||
| let photonic_vector = self.holographic_port.compress_context(data_str).await?; | ||
| self.network_port.dht_put(dht_key, photonic_vector).await?; | ||
| Ok(...) | ||
| } |
There was a problem hiding this comment.
In the store_photonic code snippet, the variable dht_key is used but not defined. It should be initialized using Self::dht_key(key) to match the actual implementation in PhotonicDhtAdapter.
| pub async fn store_photonic(&self, key: &str, data_str: &str) -> Result<(usize, usize)> { | |
| let photonic_vector = self.holographic_port.compress_context(data_str).await?; | |
| self.network_port.dht_put(dht_key, photonic_vector).await?; | |
| Ok(...) | |
| } | |
| pub async fn store_photonic(&self, key: &str, data_str: &str) -> Result<(usize, usize)> { | |
| let dht_key = Self::dht_key(key); | |
| let photonic_vector = self.holographic_port.compress_context(data_str).await?; | |
| self.network_port.dht_put(dht_key, photonic_vector).await?; | |
| Ok(...) | |
| } |
| ### 3. Ingestion Gateway | ||
|
|
||
| Data enters the system via the Axum-based WebSocket gateway at `/stream`. The `synapse-cli` daemon listens for incoming connections and routes messages to the metabolism. | ||
|
|
||
| ```rust | ||
| // crates/synapse-cli/src/commands.rs | ||
| .route("/stream", get(ws_handler)) | ||
| ``` | ||
|
|
||
| ### 4. Sender: HologramStreamEncoder | ||
| ### 5. Receiver: HologramStreamDecoder |
There was a problem hiding this comment.
The headers in this section have numbering inconsistencies and a redundant entry. ### 4. Sender: HologramStreamEncoder is duplicated (already defined as section 3 on line 70) and has no content. Let's correct the numbering and remove the redundant header:
### 4. Ingestion Gateway
Data enters the system via the Axum-based WebSocket gateway at `/stream`. The `synapse-cli` daemon listens for incoming connections and routes messages to the metabolism.
```rust
// crates/synapse-cli/src/commands.rs
.route("/stream", get(ws_handler))5. Receiver: HologramStreamDecoder
1 participant
This PR performs a comprehensive cleanup and update of the Synapse Protocol documentation to align with the new strategic direction: a Decentralized P2P Ingestion Network leveraging Photonic (Holographic) Transport.
Key changes:
/streamendpoint as the primary ingestion vector.docs/CRYSTAL_LOGIC_ARCHITECTURE.mdto include references toPhotonicDhtAdapterand the Axum gateway, ensuring the documentation matches the latest infrastructure adapters.docs/anddocs/agent-docs/that referenced old blockchain decisions or temporary planning phases no longer relevant to the current "Photonic" model..rs,.toml) were modified, maintaining strict separation between documentation updates and logic.Fixes #785
PR created automatically by Jules for task 1809302057467993357 started by @iberi22