Favicon: always the transparent beacon; manifest reachable when signed out - #121
Merged
Conversation
The middleware matcher excludes image extensions but not .json, so the browser's credential-less manifest fetch was 307-redirected to /login and served HTML — no PWA manifest, no install icons, for anyone not signed in. The manifest joins sw.js and favicon.ico in the static-file skip; it contains only public branding. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TArsz4CrMDAKmeALMozkR5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The tab icon turned blue after sign-in: DynamicFavicon swapped the static favicon for /api/favicon's status-plated version (blue connected, amber offline, slate default). Status belongs to in-app UI, not the favicon — the tab now always shows the transparent beacon from favicon.ico/icon.svg. DynamicFavicon, useDynamicFavicon and the /api/favicon route are deleted, the manifest's icons point at the static beacon PNGs instead of the API, and /api/favicon leaves the middleware's public list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TArsz4CrMDAKmeALMozkR5
ib823
changed the title
ib823
marked this pull request as ready for review
August 8, 2026 23:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two issues surfaced while verifying #120 in production:
DynamicFaviconclient system replaced the static favicon with/api/favicon's status-plated version — blue plate when authenticated, amber when offline, slate by default. The owner wants the clean transparent beacon in the tab at all times./manifest.jsonwas 307-redirected to/loginfor signed-out visitors: the middleware matcher excludes image extensions but not.json, so the browser's credential-less manifest fetch got HTML and the PWA manifest (and install icons) never loaded pre-login.What changed
DynamicFavicon,useDynamicFaviconand the/api/faviconroute are deleted; the tab always shows the static transparent beacon (favicon.icosize ramp +icon.svg) declared in layout metadata. Status signaling stays with in-app UI (SyncChip, banners).manifest.jsonicons now point at the static beacon PNGs (192/512/maskable/apple-touch) instead of the deleted API, and/api/faviconleaves the middleware public list./manifest.jsonjoinssw.jsandfavicon.icoin the middleware's static-file skip — it contains only public branding.Verification
tsc --noEmitclean,next lint --max-warnings=0clean, production build succeeds/manifest.json→ 200application/json; tab icon stays the transparent beacon before and after sign-in🤖 Generated with Claude Code
https://claude.ai/code/session_01TArsz4CrMDAKmeALMozkR5