All flagged old-UI surfaces rebuilt on the design system - #119
Merged
Conversation
Response to "/dashboard still old UI … /gantt-tool (Context) old UI … /architecture/v3 old UI … /admin/users old UI". The earlier slices had replaced shells and the canvas; the content inside these four surfaces was still the old components. Now rebuilt on ds, behavior preserved: - /dashboard: stat tiles and quick-action link cards on ds PageHeader/ Card with token-only CSS; MetricCard and QuickActionCard deleted. Same fetches, same admin gating; router.push buttons became real links. - /admin/users: UserManagementClient rewritten without antd (zero antd imports remain) on ds DataTable/Modal/Field/Input/Select/StatusPill; identical endpoints, bodies, validation and security semantics; delete is the two-step ds confirm naming the user. One latent bug fixed: a blank name is now omitted from the PATCH body instead of being sent as null, which the schema rejected with a 400. - Gantt Context tab: ds Cards/Fields/Textareas/Buttons; DOMPurify sanitisation, exact API body, dirty tracking, ⌘S — all unchanged. - /architecture/v3: the hand-rolled tab strip replaced by ds Tabs (arrow-key navigation comes from the composite); all three tab bodies (~2,200 lines) restyled onto ds Cards/DataTables/Banners/ StatusPills/Modals with data shapes byte-identical; the team sidebar chrome tokenised, resize behavior kept. Also in this commit: - The orphaned-resource repair tool rehomed as a ds warning banner on the Timeline surface (it lost its home when the legacy side panel was deleted): appears only when manager references are broken, explains the consequence, one-click repair. - Dead e2e specs deleted (view-switching, plan-timeline placeholders, visual-regression/*, user-journeys/*): every one asserted the removed legacy UI, a ?view= model that never existed, or routes this app does not have. smoke, login-flows and team-capacity-api remain. - The "restore-drill risk" for the two production-only migrations is closed as a non-issue and documented: 0_init already contains their objects, so a fresh restore reproduces the live schema; matching files would double-apply DDL and break restores. Verified: tsc, lint, 1776 unit tests, fresh production build with all 23 bundle budgets green. Per-surface verification by parallel rebuild agents included the admin aria-label suite (16 tests) and the architecture API-shape tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TArsz4CrMDAKmeALMozkR5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ib823
marked this pull request as ready for review
August 8, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to the flagged surfaces still showing old UI. All four rebuilt on ds with behavior preserved:
PageHeader/Card, token-only CSS;MetricCard/QuickActionCarddeleted; same fetches and admin gating.UserManagementClientrewritten without antd (zero antd imports) on dsDataTable/Modal/Input/Select/StatusPill; identical endpoints, validation and security semantics; two-step ds delete confirm. One latent bug fixed: blank name omitted from the PATCH body instead of a schema-rejectednull.Tabs(arrow-key nav from the composite); all three tab bodies (~2,200 lines) restyled onto ds Cards/DataTables/Banners/StatusPills/Modals with saved data shapes byte-identical; team sidebar chrome tokenised.Also: the orphaned-resource repair tool rehomed as a ds warning banner on the Timeline surface; dead e2e specs deleted (they asserted the removed legacy UI or routes that don't exist); the two production-only migrations documented as a non-issue (
0_initalready contains their objects).Verified: tsc, lint, 1776 unit tests, fresh production build with all 23 bundle budgets green; admin aria-label suite (16 tests) and architecture API-shape tests green.
Generated by Claude Code