Skip to content

Fix Reader.stream functions #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianic merged 1 commit into from
Jan 26, 2026
Merged

Fix Reader.stream functions #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/Socket.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub const Reader = struct {

fn stream(r: *Io.Reader, w: *Io.Writer, limit: Io.Limit) Io.Reader.StreamError!usize {
const self: *Reader = @fieldParentPtr("interface", r);
const buf = limit.slice(w.unusedCapacitySlice());
const buf = limit.slice(try w.writableSliceGreedy(1));

while (true) {
var iov: [1]posix.iovec = .{
Expand Down
3 changes: 2 additions & 1 deletion src/connection.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ pub const Connection = struct {

fn stream(r: *Io.Reader, w: *Io.Writer, limit: Io.Limit) Io.Reader.StreamError!usize {
const self: *Reader = @fieldParentPtr("interface", r);
const n = self.conn.read(limit.slice(w.unusedCapacitySlice())) catch |err| {
const buf = limit.slice(try w.writableSliceGreedy(1));
const n = self.conn.read(buf) catch |err| {
self.err = err;
if (err == error.EndOfStream) return error.EndOfStream;
return error.ReadFailed;
Expand Down
Loading