integration: add mockgrbl realtime hold/resume and status-report tests#80
Merged
ianbruene merged 1 commit intoJul 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mockgrbl_e2eintegration suite to cover realtime feed-hold/cycle-start behavior during active motion and to verify controller status/report consistency while motion is active and after completion.Description
TestDDGoRealtimeHoldResumeDuringJogAgainstMockwhich drives a long X jog via the realapp.Controller, issuesgrbl.ActionHoldandgrbl.ActionResume, asserts the mock materializes a held/cancelled position between start and target, verifies the mock logged the realtime hold, and verifies resume does not restart the cancelled jog.TestDDGoStatusReportsDuringAndAfterMockJogwhich starts a short X jog, requests explicit status while the mock is moving and after natural completion, and asserts the controller snapshot showsJogwhile moving,Idleafter completion, and thatLastStatusRawis present.hasMockLogEntryto flexibly assert mock event/response text without brittle exact-match expectations, and keep the existing//go:build linux && serial && mockgrbl_e2escope and the real serial transport.internal/integration/mockgrbl/mockgrbl_e2e_test.go; no production code or CI workflows were modified.Testing
gofmt -w internal/integration/mockgrbl/mockgrbl_e2e_test.goand the file formatting check passed.go test -tags 'serial mockgrbl_e2e' ./internal/integration/mockgrbland the mockgrbl integration suite passed.go test ./...andgo test -tags serial ./internal/transport ./internal/ports ./internal/app ./internal/grbland all targeted packages passed.Codex Task